fix(invoice): drop fulfillmentOrders query (scope-denied), keep shippingLine pickup heuristic

Querying Order.fulfillmentOrders.deliveryMethod requires the
read_merchant_managed_fulfillment_orders scope (not read_orders, despite
what shopify.dev claims) and was failing with 'Access denied for
fulfillmentOrders field' against real stores.

Adding that scope would force every install to re-grant permissions, so
instead we rely on shippingLine alone:

- Shopify Local Pickup app: shippingLine.code = 'Pickup' (caught by the
  regex) and shippingLine.title is the chosen location name itself   (e.g. 'Lager Graz') \u2014 perfect as pickupLocationName.
- Custom-rate pickup ('Abholung im Lager'): regex matches title/code,
  title is used as the location hint.

Removes RawDeliveryMethod, the deliveryMethods field on RawOrderForInvoice,
and the fulfillmentOrders edges from RawAdminResponse.

This commit is contained in:

Gerhard Scheikl

2026-05-15 15:04:16 +02:00

parent d742e75419

commit f16ef4e103

5 changed files with 209 additions and 78 deletions

									
										app/services/invoice/loadDraftOrderForOffer.server.ts
									
		-1
	
												View File
												
				@@ -163,7 +163,6 @@ export async function loadDraftOrderForOffer(

				    paymentGatewayNames: [],

				    shippingLine: null,

				    fulfillments: [],

				    deliveryMethods: [],

				    discountCodes: [],

				    taxesIncluded: draft.taxesIncluded,

				    customer: draft.customer,